Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Only use master test runs for status badge #3475

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

iCiaran
Copy link
Contributor

@iCiaran iCiaran commented Feb 11, 2025

Before this change the most recent run from any branch was used for the badge, which could have been a failed run on a branch (for example earlier today the most recent run was https://github.com/google/go-github/actions/runs/13250097376/job/36985764795 and the readme showed the test status as failing).

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @iCiaran !
LGTM
Merging.

Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.03%. Comparing base (26f71a3) to head (6a762c8).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3475   +/-   ##
=======================================
  Coverage   91.03%   91.03%           
=======================================
  Files         179      179           
  Lines       15538    15538           
=======================================
  Hits        14145    14145           
  Misses       1221     1221           
  Partials      172      172           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gmlewis gmlewis merged commit ce42642 into google:master Feb 11, 2025
7 checks passed
@iCiaran iCiaran deleted the tests-badge-master branch February 12, 2025 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants