-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Add support for the security and analysis webhook event #2862
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for the security and analysis webhook event #2862
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @byronwolfman !
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
Codecov Report
@@ Coverage Diff @@
## master #2862 +/- ##
=======================================
Coverage 98.07% 98.07%
=======================================
Files 139 139
Lines 12342 12344 +2
=======================================
+ Hits 12104 12106 +2
Misses 162 162
Partials 76 76
|
Thanks, sounds good! And thanks for the clear contributing docs that made it possible to put this together. 🙏 💯 |
Thank YOU for reading it! It would be nice if every PR author read it!!! 😂 |
Good morning! What sort of timeline should we expect for merging, and/or what trees do we need to shake? :D |
This repo is maintained by volunteers and for this PR we need another contributor to this repo to perform a second code review before this will be merged. Feel free to request code reviews from other contributors to this repo to move the process along. Thanks. |
Gently tagging @jporzucek for review as I see you've done some recent work on security and analysis APIs. 🙏 |
LGTM! 🚀 |
Thank you, @jporzucek ! |
cc: @evankanderson - this will also affect #2865. Sorry about that. |
Fixes #2861
Adds support for the Security and Analysis webhook event which fires whenever security and analysis features are enabled or disabled for a repository.
go generate
go test
go vet