Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docstore/all: add Offset method implementation #3385

Merged
merged 5 commits into from Mar 1, 2024

Conversation

bartventer
Copy link
Contributor

This pull request adds an Offset method to the docstore package for all providers. This method allows users to skip a specified number of documents in the results of a query, which is useful for implementing pagination in applications that use docstore. This complements the existing Limit method.

I've tested this implementation across all providers and generated new replay files for awsdynamodb and gcpfirestore.

This commit adds an Offset method to the docstore package to allow users to skip a specified number of documents in the results of a query. This is useful for implementing pagination in applications that use docstore.
Copy link

codecov bot commented Feb 26, 2024

Codecov Report

Attention: Patch coverage is 92.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 73.15%. Comparing base (5ec203b) to head (ce7cb1b).
Report is 2 commits behind head on master.

Files Patch % Lines
docstore/query.go 77.77% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3385      +/-   ##
==========================================
- Coverage   73.18%   73.15%   -0.04%     
==========================================
  Files         113      113              
  Lines       14792    14846      +54     
==========================================
+ Hits        10826    10860      +34     
- Misses       3202     3213      +11     
- Partials      764      773       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@vangent vangent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@vangent vangent merged commit 0059557 into google:master Mar 1, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants