Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix License #8253

Merged
merged 1 commit into from
Mar 11, 2024
Merged

Fix License #8253

merged 1 commit into from
Mar 11, 2024

Conversation

p0fi
Copy link
Contributor

@p0fi p0fi commented Mar 11, 2024

馃摉 Description

The previous license value was not suitable for most software license scanners. Listing the actual license string in the package.json fixes this

The previous license value was not suitable for most software license scanners. Listing the actual license string in the package.json fixes this
@github-actions github-actions bot added the json label Mar 11, 2024
@p0fi
Copy link
Contributor Author

p0fi commented Mar 11, 2024

It seems that the build on macOS is broken on master due to a warning which is treated as an error due to -Werror. Here is the run: https://buildkite.com/bazel/flatbuffers/builds/9312#018e2de2-ad09-403d-b3c8-1cfb90b958b0

@dbaileychess
Copy link
Collaborator

Why is this an issue now? I did a trivial change a year ago with the same textual blurb?

d44ce00

@dbaileychess dbaileychess merged commit b1f617f into google:master Mar 11, 2024
43 of 44 checks passed
This was referenced Mar 11, 2024
@p0fi
Copy link
Contributor Author

p0fi commented Mar 12, 2024

For us its an issue now since we started to use flatbuffers this week :D
Thanks for merging! 馃憤

@p0fi p0fi deleted the fix-license-info branch March 12, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants