Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@InlineMe patching of Guava's Strings.repeat produces broken code #4819

Closed
lepistone opened this issue Feb 11, 2025 · 0 comments
Closed

@InlineMe patching of Guava's Strings.repeat produces broken code #4819

lepistone opened this issue Feb 11, 2025 · 0 comments

Comments

@lepistone
Copy link

We found a situation where patching of an InlineMe annotation in Guava produces broken code.

When patching the line:

int i = 10;
System.out.println(Strings.repeat("item-" + i, 10));

This produces the broken line:

System.out.println("res-" + i.repeat(10));

The correct replacement needs parentheses:

System.out.println(("res-" + i).repeat(10));

Thanks!
copybara-service bot pushed a commit that referenced this issue Feb 28, 2025
@graememorgan
Try to detect whether inlining a parameter might require parentheses.

Verified

This commit was signed with the committer’s verified signature.
MarcoPolo Marco Munizaga
GPG key ID: E747E431D981A953
Verified
Learn about vigilant mode
Loading
Loading status checks…
2cb1625 
Fixes external #4819

PiperOrigin-RevId: 730861379
@copybara-service copybara-service bot mentioned this issue Feb 28, 2025
Merged
copybara-service bot pushed a commit that referenced this issue Feb 28, 2025
@graememorgan
Try to detect whether inlining a parameter might require parentheses.

Verified

This commit was signed with the committer’s verified signature.
MarcoPolo Marco Munizaga
GPG key ID: E747E431D981A953
Verified
Learn about vigilant mode
Loading
Loading status checks…
26d2c90 
Fixes external #4819

PiperOrigin-RevId: 730861379
copybara-service bot pushed a commit that referenced this issue Feb 28, 2025
@graememorgan
Try to detect whether inlining a parameter might require parentheses.
Loading
Loading status checks…
5465be5 
Fixes external #4819

PiperOrigin-RevId: 730861379
copybara-service bot pushed a commit that referenced this issue Feb 28, 2025
@graememorgan
Try to detect whether inlining a parameter might require parentheses.
Loading
Loading status checks…
ecb990c 
Fixes external #4819

PiperOrigin-RevId: 732240834
@cushon cushon mentioned this issue Mar 4, 2025
Open
svc-squareup-copybara pushed a commit to cashapp/misk that referenced this issue Mar 21, 2025
@github-cash-renovate-jvm-2 @svc-squareup-copybara
This PR contains the following updates:
Loading
Loading status checks…
0368ff2 
| Package | Type | Package file | Manager | Update | Change |
|---|---|---|---|---|---|
| [com.google.guava:guava-bom](https://github.com/google/guava)
([source](http://svn.sonatype.org/spice/trunk/oss/oss-parent-9)) |
dependencies | misk/gradle/libs.versions.toml | gradle | patch |
`33.4.0-jre` -> `33.4.5-jre` |
|
[com.google.apis:google-api-services-storage](http://nexus.sonatype.org/oss-repository-hosting.html)
([source](http://svn.sonatype.org/spice/tags/oss-parent-7)) |
dependencies | misk/gradle/libs.versions.toml | gradle | patch |
`v1-rev20250224-2.0.0` -> `v1-rev20250312-2.0.0` |
|
[com.google.errorprone:error_prone_annotations](https://errorprone.info)
([source](https://github.com/google/error-prone)) | dependencies |
misk/gradle/libs.versions.toml | gradle | minor | `2.36.0` -> `2.37.0` |
|
[com.autonomousapps.dependency-analysis](https://github.com/autonomousapps/dependency-analysis-android-gradle-plugin)
| plugin | misk/gradle/libs.versions.toml | gradle | minor | `2.12.0` ->
`2.13.0` |
| [software.amazon.awssdk:sdk-core](https://aws.amazon.com/sdkforjava) |
dependencies | misk/gradle/libs.versions.toml | gradle | patch |
`2.31.3` -> `2.31.4` |
| [software.amazon.awssdk:sqs](https://aws.amazon.com/sdkforjava) |
dependencies | misk/gradle/libs.versions.toml | gradle | patch |
`2.31.3` -> `2.31.4` |
|
[software.amazon.awssdk:dynamodb-enhanced](https://aws.amazon.com/sdkforjava)
| dependencies | misk/gradle/libs.versions.toml | gradle | patch |
`2.31.3` -> `2.31.4` |
| [software.amazon.awssdk:dynamodb](https://aws.amazon.com/sdkforjava) |
dependencies | misk/gradle/libs.versions.toml | gradle | patch |
`2.31.3` -> `2.31.4` |
| [software.amazon.awssdk:aws-core](https://aws.amazon.com/sdkforjava) |
dependencies | misk/gradle/libs.versions.toml | gradle | patch |
`2.31.3` -> `2.31.4` |
| [software.amazon.awssdk:bom](https://aws.amazon.com/sdkforjava) |
dependencies | misk/gradle/libs.versions.toml | gradle | patch |
`2.31.3` -> `2.31.4` |
| [software.amazon.awssdk:auth](https://aws.amazon.com/sdkforjava) |
dependencies | misk/gradle/libs.versions.toml | gradle | patch |
`2.31.3` -> `2.31.4` |

---

### Release Notes

<details>
<summary>google/error-prone
(com.google.errorprone:error_prone_annotations)</summary>

###
[`v2.37.0`](https://github.com/google/error-prone/releases/tag/v2.37.0):
Error Prone 2.37.0

Changes:

- The annotations that were previously in `error_prone_type_annotations`
have been been merged into `error_prone_annotations`.
`error_prone_type_annotations` is now deprecated, and will be removed in
a future release.

New checks:

-
[`AssignmentExpression`](https://errorprone.info/bugpattern/AssignmentExpression)
- The use of an assignment expression can be surprising and hard to
read; consider factoring out the assignment to a separate statement.
-
[`IntFloatConversion`](https://errorprone.info/bugpattern/IntFloatConversion)
- Detect calls to `scalb` that should be using the double overload
instead
- [`InvalidSnippet`](https://errorprone.info/bugpattern/InvalidSnippet)
- Detects snippets which omit the `:` required for inline code.
-
[`JUnit4EmptyMethods`](https://errorprone.info/bugpattern/JUnit4EmptyMethods)
- Detects empty JUnit4 `@Before`, `@After`, `@BeforeClass`, and
`@AfterClass` methods.
-
[`MockIllegalThrows`](https://errorprone.info/bugpattern/MockIllegalThrows)
- Detects cases where Mockito is configured to throw checked exception
types which are impossible.
-
[`NegativeBoolean`](https://errorprone.info/bugpattern/NegativeBoolean)
- Prefer positive boolean names.
- [`RuleNotRun`](https://errorprone.info/bugpattern/RuleNotRun) -
Detects `TestRule`s not annotated with `@Rule`, that won't be run.
-
[`StringConcatToTextBlock`](https://errorprone.info/bugpattern/StringConcatToTextBlock)
- Replaces concatenated multiline strings with text blocks.
-
[`TimeInStaticInitializer`](https://errorprone.info/bugpattern/TimeInStaticInitializer)
- Detects accesses of the system time in static contexts.

Closed issues:

- Propagate check flags in patch mode
([#&#8203;4699](google/error-prone#4699))
- Fixes a crash in ComputeIfAbsentAmbiguousReference
([#&#8203;4736](google/error-prone#4736))
- Show the field name in HidingField diagnostics
([#&#8203;4775](google/error-prone#4775))
- Add support for jakarta annotations to some checks
([#&#8203;4782](google/error-prone#4782))
- FloatingPointAssertionWithinEpsilonTest depends on default locale
([#&#8203;4815](google/error-prone#4815))
- `@InlineMe` patching of `Strings.repeat` produces broken code
([#&#8203;4819](google/error-prone#4819))
- Fix a crash in IdentifierName on unnamed (`_`) variables
([#&#8203;4847](google/error-prone#4847))
- Fix a crash in ArgumentParameterSwap
([#&#8203;490](google/error-prone#490))

Full changelog:
google/error-prone@v2.36.0...v2.37.0

</details>

<details>
<summary>autonomousapps/dependency-analysis-android-gradle-plugin
(com.autonomousapps.dependency-analysis)</summary>

###
[`v2.13.0`](https://github.com/autonomousapps/dependency-analysis-android-gradle-plugin/blob/HEAD/CHANGELOG.md#Version-2130)

- \[Feat]: `computeResolvedDependencies` to also generate a version
catalog file
- \[Feat]: experimenting with compressing intermediates, starting with
`exploded-jars.json`.
-   \[Chore]: remove unused moshi functions.

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am
every weekday" in timezone Australia/Melbourne, Automerge - At any time
(no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Never, or you tick the rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://github.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://github.com/renovatebot/renovate).

GitOrigin-RevId: 9a8acb12117486aa61b1d54c73d77d84629e5e79
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lepistone @graememorgan