Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CanIgnoreReturnValueSuggester: Support additional exempting method annotations #4009

Closed
wants to merge 1 commit into from
Closed

CanIgnoreReturnValueSuggester: Support additional exempting method annotations #4009

wants to merge 1 commit into from

Conversation

rickie
Copy link
Contributor

@rickie rickie commented Jul 11, 2023

While there, excempt @AfterTemplate methods with analysis.

@rickie rickie mentioned this pull request Jul 11, 2023
Closed
@rickie
CanIgnoreReturnValueSuggester: Support custom exempting method annota…
fd25f02 
…tions

While there, excempt `@AfterTemplate` methods with analysis.
@rickie rickie force-pushed the rossendrijver/CIRV_Refaster branch from 454bdd4 to fd25f02 Compare August 29, 2023 09:19
@rickie
Copy link
Contributor Author

rickie commented Aug 29, 2023

Rebased.

@cushon
Copy link
Collaborator

cushon commented Sep 6, 2023

I would like @kluever's input.

For the com.google.errorprone.refaster.annotation.AfterTemplate use-case, has there been any discussion of making CIRV a meta-annotation that could be applied to AfterTemplate?

@cushon
Copy link
Collaborator

cushon commented Sep 7, 2023

has there been any discussion of making CIRV a meta-annotation that could be applied to AfterTemplate?

I couldn't find any discussion of this, and I also think it's fine to not open that can of worms for this use-case :)

copybara-service bot pushed a commit that referenced this pull request Sep 7, 2023
@rickie
CanIgnoreReturnValueSuggester: Support additional exempting method an…
6d876a3 
…notations

While there, excempt `@AfterTemplate` methods with analysis.

Fixes #4009

FUTURE_COPYBARA_INTEGRATE_REVIEW=#4009 from PicnicSupermarket:rossendrijver/CIRV_Refaster fd25f02
PiperOrigin-RevId: 563504684
@copybara-service copybara-service bot mentioned this pull request Sep 7, 2023
Closed
@copybara-service copybara-service bot closed this in 6ca3f0a Sep 7, 2023
@Stephan202 Stephan202 deleted the rossendrijver/CIRV_Refaster branch September 13, 2023 16:31
@carterkozak carterkozak mentioned this pull request Oct 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cushon cushon cushon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rickie @cushon