Add tests for JSPM and Vite #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jathak
reviewed
Mar 9, 2023
Also work around vitejs/vite#12340
jathak
approved these changes
Mar 10, 2023
browser_library_test/package.json
Outdated
| }, | ||
| "dependencies": { | ||
| "@jspm/generator": "^1.1.0", | ||
| "vite": "^4.1.4" |
There was a problem hiding this comment.
Is there a reason why this is a regular dependency instead of a dev dependency?
There was a problem hiding this comment.
This package is never going to be distributed anywhere so it kind of doesn't matter either way, but I'll make them dev dependencies for consistency.,
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.