Add test_suite and test_config under conformance #441
Merged
+1,804
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
aakash070
commented
Feb 18, 2025
•
aakash070
commented
- Adding env_config under conformance to represent a serializable format for CEL environment. This can be used to create a new or augment an existing CEL environment.
- Added new test suite structure to simple.proto. This new schema can support the existing features of simple test as well as be used by the CEL test runner for triggering unit tests to validate user expressions and policies. The conformance tests will be updated in a follow up pull request.
|
/gcbrun |
|
/gcbrun |
| @@ -141,3 +145,107 @@ message UnknownSetMatcher { | |||
| // Success if we match any of these sets. | |||
| repeated cel.expr.UnknownSet unknowns = 1; | |||
| } | |||
|
|
|||
| // A test suite is a collection of tests designed to evaluate the correctness of | |||
There was a problem hiding this comment.
I don't mind putting the tests suite and test section into a separate file, just wanted it to live under conformance/test. Perhaps, conformance/test/suite.proto?
There was a problem hiding this comment.
Should we also move test case to the new file, as it's only being referenced by test section? This new file will then act as a complete replacement of simple.proto.
There was a problem hiding this comment.
it will also make the conformance tests migration to the new test suite a bit more straight forward.
TristonianJones
previously approved these changes
Feb 25, 2025
|
/gcbrun |
TristonianJones
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.