tests to verify parsers ignore whitespace and comments #430
+47
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hudlow
commented
Dec 24, 2024
Comment on lines
176
to
181
| test { | ||
| name: "carriage_return_terminated" | ||
| description: "Check that carriage-return-terminated comments are ignored." | ||
| expr: "[// @\r.// @\rcel.// @\rexpr// @\r.conformance.// @\rproto3.// @\rTestAllTypes// @\r{// @\rsingle_int64// @\r:// @\rint// @\r(// @\r17// @\r)// @\r}// @\r.// @\rsingle_int64// @\r]// @\r[// @\r0// @\r]// @\r==// @\r(// @\r18// @\r-// @\r1// @\r)// @\r&&// @\r!// @\rfalse// @\r?// @\r1// @\r:// @\r2" | ||
| value { int64_value: 1 } | ||
| } |
There was a problem hiding this comment.
cel-go currently fails this, but it is legal per the grammar. I did not check other implementations.
There was a problem hiding this comment.
I think the antlr grammars are specifically looking for LF '\n' to terminate the comment so this will fail for the implementations we maintain (Java/C++/Go). I'm not sure if we should update the cel-spec description of the grammar or the implementations for this case. I'll defer to @TristonianJones
There was a problem hiding this comment.
At the moment, it's probably best to update the grammar in cel-spec and revisit whether adding \r termination is needed.
There was a problem hiding this comment.
Updated the grammar.
|
/gcbrun |
hudlow
force-pushed
the
whitespace-comment-testing
branch
from
76b15cc to
4998d59
Compare
hudlow
commented
Jan 10, 2025
|
/gcbrun |
TristonianJones
approved these changes
Jan 10, 2025
|
Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.