Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev: fix JSONSchema publication #5395

Merged
merged 1 commit into from
Feb 12, 2025
Merged

Conversation

ldez
Copy link
Member

@ldez ldez commented Feb 12, 2025

Multiple reads of the same io.Reader.

@ldez ldez added bug Something isn't working area: JSON schema labels Feb 12, 2025
@ldez ldez added this to the next milestone Feb 12, 2025
@ldez
Copy link
Member Author

ldez commented Feb 12, 2025

I bypass the requirements to fix the problem quickly.

@ldez ldez merged commit f5396bd into golangci:master Feb 12, 2025
10 of 14 checks passed
@ldez ldez deleted the fix/jsonschema-publish branch February 12, 2025 02:18
Copy link
Member

@alexandear alexandear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can add tests that decrease chances of problems during a future release.

@ldez ldez modified the milestones: next, v1.64 Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: JSON schema bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants