build(deps): bump go-simpler.org/sloglint from 0.5.1 to 0.6.0 #4645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmzane
commented
Apr 15, 2024
ldez
added
dependencies
ldez
requested changes
Apr 15, 2024
There was a problem hiding this comment.
You should not modify:
.golangci.reference.ymljsonschema/golangci.jsonschema.json
Also context-only should be removed from:
.golangci.next.reference.ymljsonschema/golangci.next.jsonschema.json
I think context is good, at least less weird than no-contextless (IMHO it's not easier to understand)
The values can be improved, for example:
all->alwaysscope->existing
If it is removed from the next version schema, won't it become illegal to use in the config? Thus, breaking backward compatibility with existing configs. |
"illegal" no 😄 The JSON schema validation is only called explicitly, but the deprecation warning will always display, so everything will still work as expected. |
tmzane
force-pushed
the
sloglint-context-only
branch
from
991592c
to
0a8aaad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In continuation to #4512
Not sure about the new name,
contextdoes not seem descriptive to me. Maybe something likeno-contextless? Weird, but easier to understand.Please don't merge it yet, I'm going to update the pinned version later.
I've also improved the report message slightly.
go-simpler/sloglint@v0.5.1...v0.6.0