Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix default value for sloglint no-global #4547

Merged
merged 1 commit into from Mar 20, 2024
Merged

docs: fix default value for sloglint no-global #4547

merged 1 commit into from Mar 20, 2024

Conversation

tmzane
Copy link
Contributor

@tmzane tmzane commented Mar 20, 2024 •
edited

Also added description for the values.

@ldez ldez added area: config Related to .golangci.yml and/or cli options linter: update Update the linter implementation inside golangci-lint area: JSON schema labels Mar 20, 2024
@ldez ldez added this to the next milestone Mar 20, 2024
@ldez ldez added area: docs bug Something isn't working labels Mar 20, 2024
ldez
ldez approved these changes Mar 20, 2024
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez merged commit 9d6d793 into golangci:master Mar 20, 2024
13 checks passed
@tmzane tmzane deleted the sloglint-no-global-default branch March 20, 2024 11:53
@ldez ldez modified the milestones: next, v1.57 Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldez ldez ldez approved these changes

Assignees
No one assigned
Labels
area: config Related to .golangci.yml and/or cli options area: docs area: JSON schema bug Something isn't working linter: update Update the linter implementation inside golangci-lint
Projects
None yet
Milestone
v1.57
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tmzane @ldez