Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump github.com/nunnatsa/ginkgolinter from 0.15.2 to 0.16.0 #4530

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 18, 2024

Bumps github.com/nunnatsa/ginkgolinter from 0.15.2 to 0.16.0.

Release notes

Sourced from github.com/nunnatsa/ginkgolinter's releases.

v0.16.0

What's Changed

New Rules

Optional Rule: Force Expect with To [STYLE]

Trigger warning when using Expect with Should or ShouldNot`; e.g.

Expect(err).ShouldNot(HaveOccurred())

Should be

Expect(err).ToNot(HaveOccurred())

This rule is optional. Add the --force-expect-to=true to enable this rule.

Rule: cap assertion [STYLE]

Very similar to the len rule. The linter triggers a warning when using

Expect(cap(slice)).To(Equal(3))

Instead, the linter suggests

Expect(slice).To(HaveCap(3))

This rule is now part of the len rule. It uses the same configurations:

  • enabled by default
  • To suppress this warning, use the --suppress-len-assertion=true flag.
  • To suppress this warning for a file, add a comment in the top of the file:
    // ginkgo-linter:ignore-len-assert-warning
  • To suppress this warning for a specific expression, add the comment above the expression:
    // ginkgo-linter:ignore-len-assert-warning
    Expect(cap(slice)).To(Equal(3))

Optional Rule: validate async intervals [BUG and STYLE]

Note: This rule works as best-effort. It can't catch all cases.

This rule is disable by default. Use the --validate-async-intervals=true flag to enable it. Also, the --suppress-async-assertion flag must not be set to true. In this case, this rule is disabled.

This rule is actually three sub-rules

Timeout Must be Longer than Polling [BUG]

In async assertions (Eventually or Consistently), the linter checks that the timeout is not shorter than the polling interval.

For example:

Eventually(..., time.Millisecond * 500 /*timeout*/, 10 * time.Second /*polling*/)
// or:
</tr></table> 

... (truncated)

Commits
  • f0bf9bc Fix go.sum
  • 089e08f Chore: bump golang.org/x/exp/typeparams
  • 8b053db New Rule: Avoid spec Pollution
  • 3dae9c1 Chore: move some packages to the new internal dir
  • 2973d69 New rule: validate async intervals
  • 4ade2b4 New Rule: cap assertion
  • 6d23c4a Bump golang.org/x/tools from 0.18.0 to 0.19.0
  • 16492e8 Bump golang.org/x/tools from 0.17.0 to 0.18.0
  • e574c36 Simplify reports
  • 1cb550c small refactoring, to split big file a bit
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [github.com/nunnatsa/ginkgolinter](https://github.com/nunnatsa/ginkgolinter) from 0.15.2 to 0.16.0.
- [Release notes](https://github.com/nunnatsa/ginkgolinter/releases)
- [Commits](nunnatsa/ginkgolinter@v0.15.2...v0.16.0)

---
updated-dependencies:
- dependency-name: github.com/nunnatsa/ginkgolinter
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Relates to an upstream dependency go Pull requests that update Go code labels Mar 18, 2024
@ldez ldez added the linter: update version Update version of linter label Mar 18, 2024
@ldez ldez self-requested a review March 18, 2024 14:15
@ldez ldez added this to the next milestone Mar 18, 2024
@ldez ldez merged commit f837070 into master Mar 18, 2024
11 checks passed
@ldez ldez deleted the dependabot/go_modules/github.com/nunnatsa/ginkgolinter-0.16.0 branch March 18, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Relates to an upstream dependency go Pull requests that update Go code linter: update version Update version of linter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant