Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump github.com/nunnatsa/ginkgolinter from 0.13.5 to 0.14.0 #4117

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 8, 2023

Bumps github.com/nunnatsa/ginkgolinter from 0.13.5 to 0.14.0.

Release notes

Sourced from github.com/nunnatsa/ginkgolinter's releases.

v0.14.0

New Rule: Prevent comparing of value from different types

The Equal and the BeIdentical gomega matchers check not only the value, but also the type.

For example:

x := uint(5)
Expect(x).Should(Equal(5))

This assertion will fail in runtime (when running the test). This is not too bad for unit tests, that can be easily run locally and be fixed, but for complex functional or e2e test, it could be hard to debug and it's not always simple to run.

In addition, it can create fals positive tests, for example:

x := uint(5)
Expect(x).ShouldNot(Equal(5))

This test will pass. The value itself is never checked, but only the type.

ginkgolinter now finds these cases and trigger warnings for them.

command line arguments

The new --suppress-type-compare-assertion=true command line argument will suppress this new rule.

Full Changelog: nunnatsa/ginkgolinter@v0.13.5...v0.14.0

Commits
  • 8a24a39 Fix the compare different type rule, to allow using WithTransform
  • 1785e17 New Rule: should not compare two different types
  • f8b13ea Bump golang.org/x/tools from 0.12.0 to 0.13.0
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [github.com/nunnatsa/ginkgolinter](https://github.com/nunnatsa/ginkgolinter) from 0.13.5 to 0.14.0.
- [Release notes](https://github.com/nunnatsa/ginkgolinter/releases)
- [Commits](nunnatsa/ginkgolinter@v0.13.5...v0.14.0)

---
updated-dependencies:
- dependency-name: github.com/nunnatsa/ginkgolinter
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Relates to an upstream dependency go Pull requests that update Go code labels Oct 8, 2023
@ldez ldez added the linter: update version Update version of linter label Oct 8, 2023
@ldez ldez merged commit 0e82ef5 into master Oct 9, 2023
11 checks passed
@ldez ldez deleted the dependabot/go_modules/github.com/nunnatsa/ginkgolinter-0.14.0 branch October 9, 2023 07:05
@ldez ldez modified the milestone: v1.55 Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Relates to an upstream dependency go Pull requests that update Go code linter: update version Update version of linter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants