Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add all directories as safe git directories inside the Docker image #4034

Merged
merged 2 commits into from Aug 21, 2023

Conversation

ldez
Copy link
Member

@ldez ldez commented Aug 21, 2023

Related to #3982 (comment)
Related to #4033 (comment)

$ git clone git@github.com:openshift-pipelines/pipelines-as-code.git
...
$ cd pipelines-as-code
$ docker run --rm -it -v $(pwd):/app -w /app golangci/golangci-lint:v1.54.1 sh
# golangci-lint run
cmd/pipelines-as-code-controller/main.go:1: : error obtaining VCS status: exit status 128
        Use -buildvcs=false to disable VCS stamping. (typecheck)
package main
cmd/pipelines-as-code-watcher/main.go:1: : error obtaining VCS status: exit status 128
        Use -buildvcs=false to disable VCS stamping. (typecheck)
package main
cmd/pipelines-as-code-webhook/main.go:1: : error obtaining VCS status: exit status 128
        Use -buildvcs=false to disable VCS stamping. (typecheck)
package main
# git config --global --add safe.directory '*'
# golangci-lint run
# 

@ldez ldez added bug Something isn't working area: docker labels Aug 21, 2023
@ldez ldez changed the title fix: add /app as a safe git directory fix(docker): add all diretories as a safe git directory Aug 21, 2023
@ldez ldez changed the title fix(docker): add all diretories as a safe git directory fix(docker): add all directories as a safe git directory Aug 21, 2023
@ldez ldez changed the title fix(docker): add all directories as a safe git directory fix(docker): add all directories as safe git directories Aug 21, 2023
@ldez ldez changed the title fix(docker): add all directories as safe git directories fix: add all directories as safe git directories inside the Docker image Aug 21, 2023
@ldez ldez merged commit 411e0bb into golangci:master Aug 21, 2023
11 checks passed
@ldez ldez deleted the fix/docker-image-git branch August 21, 2023 11:04
@ldez ldez added this to the v1.54 milestone Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: docker bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants