Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove unused from config.LintersSettings #3704

Merged
merged 1 commit into from
Mar 18, 2023

Conversation

Antonboom
Copy link
Contributor

@Antonboom Antonboom commented Mar 18, 2023

Closes #3555

without extra changes opposite #3703

Closes #3703

@Antonboom Antonboom requested a review from ldez March 18, 2023 07:36
@ldez ldez changed the title Remove unused from config.LintersSettings docs: remove unused from config.LintersSettings Mar 18, 2023
@ldez
Copy link
Member

ldez commented Mar 18, 2023

#3555 is about a problem during the generation of the doc, this PR doesn't fix the problem.

@ldez ldez closed this Mar 18, 2023
@ldez ldez added declined and removed area: docs labels Mar 18, 2023
@Antonboom
Copy link
Contributor Author

is about a problem during the generation of the doc

No, the problem is because your if hasSettings(lc.Name()) returns true for unused.
I tested this fix, please pay more attention.

@Antonboom Antonboom reopened this Mar 18, 2023
@ldez
Copy link
Member

ldez commented Mar 18, 2023

I tried it locally, and the preview doesn't detect any changes:
Screenshot 2023-03-18 at 10-41-46 Linters golangci-lint

@ldez
Copy link
Member

ldez commented Mar 18, 2023

My fault, I was a problem locally the doc was not rebuilt, it was just served previously generated content.
Sorry.

@ldez ldez added bug Something isn't working area: docs and removed declined labels Mar 18, 2023
@ldez ldez merged commit a12be2d into golangci:master Mar 18, 2023
SeigeC pushed a commit to SeigeC/golangci-lint that referenced this pull request Apr 4, 2023
@ldez ldez added this to the v1.52 milestone Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: docs bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: unused configuration broken link
2 participants