Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Options for RR #3390

Open
firelizzard18 opened this issue May 14, 2024 · 1 comment
Open

Options for RR #3390

firelizzard18 opened this issue May 14, 2024 · 1 comment
Labels
Debug Issues related to the debugging functionality of the extension. Documentation HelpWanted Issues that are not prioritized by the maintainers. Help is requested from community contributors.

Comments

@firelizzard18
Copy link
Contributor

This is a heads up and/or discussion more than a specific request. go-delve/delve#3726 will be adding two environment variables to delve to enable passing flags to rr replay and rr record. I believe I can already set environment variables for delve, so no change is needed, but for the sake of visibility it seems worth documenting. Though now that I look for it, I can't find any documentation on using RR with vscode-go beyond it being a possible backend value, so maybe this issue should be "Document debugging with RR". I also thought it could be nice to have launch options (e.g. "traceReplayFlags") that were passed to the new environment variables, but I'm fine without that.

@gopherbot gopherbot added this to the Untriaged milestone May 14, 2024
@adonovan adonovan modified the milestones: Untriaged, vscode-go/backlog May 16, 2024
@adonovan adonovan added Debug Issues related to the debugging functionality of the extension. Documentation labels May 16, 2024
@hyangah
Copy link
Contributor

hyangah commented May 16, 2024

Thanks for the information. I no longer have environment to run rr. So, any help to add info about rr in debug doc is greatly appreciated.

And, for new launch options, they should first go into the delve DAP documentation
https://pkg.go.dev/github.com/go-delve/delve/service/dap#LaunchConfig
but given that the features were implemented using env vars, I'd like to see how far we can go with the current env field.
We can improve the DAP documentation and our documentation - by mentioning backend specific env vars or adding a pointer to the delve's doc if any.

@hyangah hyangah added the HelpWanted Issues that are not prioritized by the maintainers. Help is requested from community contributors. label May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Debug Issues related to the debugging functionality of the extension. Documentation HelpWanted Issues that are not prioritized by the maintainers. Help is requested from community contributors.
Projects
None yet
Development

No branches or pull requests

4 participants