Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: require go1.13+ to install/build gopls #2030

Closed
2 tasks done
hyangah opened this issue Jan 26, 2022 · 2 comments
Closed
2 tasks done

tools: require go1.13+ to install/build gopls #2030

hyangah opened this issue Jan 26, 2022 · 2 comments
Assignees
@hyangah
Labels
FrozenDueToAge tools/installation
Milestone
v0.32.0

Comments

@hyangah
Copy link
Contributor

hyangah commented Jan 26, 2022 •
edited

gopls v0.8.0 will drop support for building at go1.12. golang/go#50827
Prevent from installing/updating gopls if the go version in use is too old.

Alternative is to install at v0.7.5 if the go version is 1.12, but given the number of users with go1.12 or older is small and users can install tools with a different version of go for tools installation so, let's not do that.
@hyangah hyangah added this to the v0.32.0 milestone Jan 26, 2022
@gopherbot
Copy link
Collaborator

Change https://golang.org/cl/381214 mentions this issue: src/goToolsInformation: require go1.13+ for gopls

hyangah added a commit to hyangah/vscode-go that referenced this issue Jan 27, 2022
@hyangah
src/goToolsInformation: require go1.13+ for gopls
0f564c5 
Gopls v0.8.0+ will require go1.13+ for build.

And, skip gopls shouldUpdateLanguageServer check.

Fixes golang#2030

Change-Id: If8fdc14553337c4a9bb3f8caae15ace2aa60e0eb
@gopherbot
Copy link
Collaborator

Change https://go.dev/cl/381214 mentions this issue: src/goToolsInformation: require go1.13+ for gopls

@hyangah hyangah self-assigned this Mar 3, 2022
@golang golang locked and limited conversation to collaborators Sep 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@hyangah hyangah

Labels
FrozenDueToAge tools/installation
Projects
None yet
Milestone
v0.32.0
Development

No branches or pull requests
2 participants
@hyangah @gopherbot