Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile: internal compiler error: panic with range over integer value [1.22 backport] #67460

Closed
gopherbot opened this issue May 17, 2024 · 3 comments
Closed

cmd/compile: internal compiler error: panic with range over integer value [1.22 backport] #67460

gopherbot opened this issue May 17, 2024 · 3 comments
Assignees
@griesemer
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime.
Milestone
Go1.22.4

Comments

@gopherbot
Copy link

@griesemer requested issue #67141 to be considered for backport to the next 1.22 minor release.

@gopherbot please consider this for backport to 1.22 and 1.21.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label May 17, 2024
@gopherbot gopherbot mentioned this issue May 17, 2024
Closed
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label May 17, 2024
@gopherbot gopherbot added this to the Go1.22.4 milestone May 17, 2024
@griesemer griesemer self-assigned this May 17, 2024
@gopherbot
Copy link
Author

Change https://go.dev/cl/586161 mentions this issue: [release-branch.go1.22] cmd/compile: initialize posBaseMap correctly

@cagedmantis cagedmantis added the CherryPickApproved Used during the release process for point releases label May 22, 2024
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label May 22, 2024
@cagedmantis
Copy link
Contributor

Approved as this is a bug with no workaround.

gopherbot pushed a commit that referenced this issue May 24, 2024
@griesemer @cagedmantis
[release-branch.go1.22] cmd/compile: initialize posBaseMap correctly
6b89e7d 
The posBaseMap is used to identify a file's syntax tree node
given a source position. The position is mapped to the file
base which is then used to look up the file node in posBaseMap.

When posBaseMap is initialized, the file position base
is not the file base if there's a line directive before
the package clause. This can happen in cgo-generated files,
for instance due to an import "C" declaration.

If the wrong file position base is used during initialization,
looking up a file given a position will not find the file.

If a version error occurs and the corresponding file is
not found, the old code panicked with a null pointer exception.

Make sure to consistently initialize the posBaseMap by factoring
out the code computing the file base from a given position.

While at it, check for a nil file pointer. This should not happen
anymore, but don't crash if it happens (at the cost of a slightly
less informative error message).

Fixes #67460.

Change-Id: I4a6af88699c32ad01fffce124b06bb7f9e06f43d
Reviewed-on: https://go-review.googlesource.com/c/go/+/586238
Reviewed-by: Robert Findley <rfindley@google.com>
Reviewed-by: Robert Griesemer <gri@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Robert Griesemer <gri@google.com>
Reviewed-on: https://go-review.googlesource.com/c/go/+/586161
@gopherbot
Copy link
Author

Closed by merging 6b89e7d to release-branch.go1.22.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@griesemer griesemer

Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime.
Projects
None yet
Milestone
Go1.22.4
Development

No branches or pull requests
3 participants
@cagedmantis @griesemer @gopherbot