Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

security: fix CVE-2024-24787 [1.22 backport] #67122

Closed
gopherbot opened this issue Apr 30, 2024 · 2 comments
Closed

security: fix CVE-2024-24787 [1.22 backport] #67122

gopherbot opened this issue Apr 30, 2024 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases release-blocker Security
Milestone
Go1.22.3

Comments

@gopherbot
Copy link

@rolandshoemaker requested issue #67119 to be considered for backport to the next 1.22 minor release.

@gopherbot please open backports, this is a PRIVATE track security issue.
@gopherbot gopherbot added CherryPickCandidate Used during the release process for point releases Security labels Apr 30, 2024
@gopherbot gopherbot mentioned this issue Apr 30, 2024
Closed
@gopherbot gopherbot added this to the Go1.22.3 milestone Apr 30, 2024
@rolandshoemaker rolandshoemaker added CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels Apr 30, 2024
@gopherbot
Copy link
Author

Change https://go.dev/cl/583796 mentions this issue: [release-branch.go1.22] cmd/go: disallow -lto_library in LDFLAGS

@gopherbot
Copy link
Author

Closed by merging fa0292d to release-branch.go1.22.

gopherbot pushed a commit that referenced this issue May 7, 2024
@rolandshoemaker @cherrymui
[release-branch.go1.22] cmd/go: disallow -lto_library in LDFLAGS
fa0292d 
The darwin linker allows setting the LTO library with the -lto_library
flag. This wasn't caught by our "safe linker flags" check because it
was covered by the -lx flag used for linking libraries. This change
adds a specific check for excluded flags which otherwise satisfy our
existing checks.

Loading a mallicious LTO library would allow an attacker to cause the
linker to execute abritrary code when "go build" was called.

Thanks to Juho Forsén of Mattermost for reporting this issue.

Fixes #67119
Fixes #67122
Fixes CVE-2024-24787

Change-Id: I77ac8585efbdbdfd5f39c39ed623b9408a0f9eaf
Reviewed-on: https://go-internal-review.googlesource.com/c/go/+/1380
Reviewed-by: Russ Cox <rsc@google.com>
Reviewed-by: Damien Neil <dneil@google.com>
(cherry picked from commit 9a79141fbbca1105e5c786f15e38741ca7843290)
Reviewed-on: https://go-internal-review.googlesource.com/c/go/+/1420
Reviewed-by: Tatiana Bradley <tatianabradley@google.com>
Reviewed-on: https://go-review.googlesource.com/c/go/+/583796
Reviewed-by: David Chase <drchase@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases release-blocker Security
Projects
None yet
Milestone
Go1.22.3
Development

No branches or pull requests
3 participants
@rolandshoemaker @gopherbot @cherrymui