New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/tools: remove usage of golang.org/x/xerrors (cleanup) #52442
Comments
Change https://go.dev/cl/401097 mentions this issue: |
Change https://go.dev/cl/401155 mentions this issue: |
Change https://go.dev/cl/401099 mentions this issue: |
Change https://go.dev/cl/401154 mentions this issue: |
Change https://go.dev/cl/401098 mentions this issue: |
As of golang/go#50827, gopls no longer supports building at 1.12, and so usage of golang.org/x/xerrors can be replaced with the native support for error wrapping introduced in Go 1.13. Remove this usage as a step toward eliminating the xerrors dependency from x/tools. For golang/go#52442 Change-Id: Ibf459cc72402a30a6c2735dc620f76ed8a5e2525 Reviewed-on: https://go-review.googlesource.com/c/tools/+/401097 Run-TryBot: Robert Findley <rfindley@google.com> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@google.com>
As of golang/go#50827, gopls no longer needs to build at Go 1.12. I believe this was the only reason to continue using xerrors in go/packages. Remove this usage as a step toward eliminating the xerrors dependency from x/tools. For golang/go#52442 Change-Id: I8f7396491be58606be6a648ebbf2180bdbc907b5 Reviewed-on: https://go-review.googlesource.com/c/tools/+/401154 Run-TryBot: Robert Findley <rfindley@google.com> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org> Reviewed-by: Ian Lance Taylor <iant@google.com>
As of golang/go#50827, gopls no longer needs to build at Go 1.12. This was the only reason to continue using xerrors in the jsonrpc2 libraries. Remove this usage as a step toward eliminating the xerrors dependency from x/tools. For golang/go#52442 Change-Id: I1a0a1bbf57e6606c66b99b27439adf6f65c26a60 Reviewed-on: https://go-review.googlesource.com/c/tools/+/401155 Run-TryBot: Robert Findley <rfindley@google.com> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@google.com> Reviewed-by: Bryan Mills <bcmills@google.com>
Go 1.12 has not been supported for a while, so it seems safe to replace usage of xerrors with the native support for wrapped errors in the standard library introduced in Go 1.13. Remove this usage as a step toward eliminating the xerrors dependency from x/tools. If there is any reason to continue to use xerrors, please let me know. For golang/go#52442 Change-Id: Ic1e5c14f4074b4685a926e884649b9032aaa0f53 Reviewed-on: https://go-review.googlesource.com/c/tools/+/401098 Run-TryBot: Robert Findley <rfindley@google.com> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@google.com>
As of #50827, we no longer support building gopls at Go 1.12.
We should remove usage of golang.org/x/xerrors from x/tools.
CC @golang/tools-team
The text was updated successfully, but these errors were encountered: