-
Notifications
You must be signed in to change notification settings - Fork 206
Add a ci-update-workflow GitHub Actions to update the go-version matrix #307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
8e06b25
to
6aae7b0
Compare
Adding jinglun as reviewer because I don't have the permission |
I think this is fine. It is a supported security feature of Github. I don't have concerns about secrets leaving GCP. We had previous campaigns to disallow exporting IAM secrets, but I believe it's a different requirement.
Sure, we should have an official project to run these commands. We could use
I don't know for sure, but I'd assume we need to configure github actions for each repo. Let's discuss that further after we finish the required setup for this repo. |
6aae7b0
to
d5de030
Compare
BTW, I'm still seeing this warning "The base branch requires all commits to be signed. Learn more about signing commits." From my previous experience, I had to fix it by another |
5c90ded
to
f0fe777
Compare
Should be good now. I had to configure the signing key on my local and also upload it to my GitHub account. I added |
f0fe777
to
62e6573
Compare
Signed-off-by: Chi Zhang <chizhg@google.com>
62e6573
to
ae54fb2
Compare
- name: Create Pull Request | ||
uses: peter-evans/create-pull-request@v4 | ||
with: | ||
token: ${{ secrets.GITHUB_TOKEN }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated to this based on the comment at GoogleCloudPlatform/functions-framework-go#177 (comment)
It turns out I need to configure |
gcloud functions runtimes list
command, and we decided to usegae-runtimes-private
After this is merged and works well, we will configure the GitHub Actions for the repos for other languages, will then decide whether to put them in each repo, or find a central location.
/cc @jihuin