Set golangci-lint to 1.54.2 (latest is broken) #1046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhui
reviewed
Mar 25, 2024
.github/workflows/ci.yaml
Outdated
| with: | ||
| version: latest | ||
| version: v1.54.2 |
There was a problem hiding this comment.
Why 1.54.2 instead of 1.57.1 which is the latest version. Per their docs, pinning the version is a good idea for reproducibility.
There was a problem hiding this comment.
The latest version as of submitting this PR (two weeks ago) was 1.56.2 which was known to be broken (e.g. the CI of migrate failed).
I am happy to test 1.57.1 when back at my dev machine.
There was a problem hiding this comment.
Looks good, reverted to "latest". So this PR currently boils down to increasing the golangci-lint-action to v4. Feel free to merge or close :)
|
@rockdaboot Thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully a temporary fix for the linter, as 1.56.2 (latest) seems to be broken.