✏️ feature: add FuncMap to Slim engine #252
Merged
+68
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efectn
commented
May 20, 2023
| for key, val := range e.funcMap { | ||
| slimFunc, ok := val.(slimFunc) | ||
| if !ok { | ||
| panic("slim: function must be compatible with slim.Func type. Slim does not support other types") |
There was a problem hiding this comment.
Should we use panic, error or just continue?
There was a problem hiding this comment.
What do you think @gaby @ReneWerner87
There was a problem hiding this comment.
Panic seems to be okay
But this works inside of Render. Is it good idea to panic on requests?
ReneWerner87
approved these changes
May 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds funcmap to Slim that wasn't added in the past.
Slim doesn't seem to support
map[string]interface{}type for funcMap. So we have to change type of funcMap or assert interface to slim function. I prefered asserting not to break compatibility with other engines.