-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Benchmarks for all engines #238
Conversation
Can you add benchmark for slim engine |
Happy to add them, however all of slim_test.go file was commented out & the Slim engine wasn't mentioned in the docs. Do you know which implementation of slim is used and I can add them tonight? |
Yeah it doesn't have docs and i've never used it before. Maybe we should try to uncomment tests and add benchmark. We will add README later |
I'll give it a try and see how I get on (no promises though!) |
@ytsruh can you pls check the tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't forget to delete ds store
Hi guys, sorry about the delay in fixing the tests. All passing now. |
will check it on sunday at the latest |
maybe we should use |
Added benchmakrs to all engines (except Mustache extended). A summary & charts were added to the README file for future reference
This is a full PR that should hopefully satisfy #227