Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃┕ Fix: dictpool is not completely gone #2540

Merged
merged 2 commits into from
Jul 11, 2023

Conversation

andre-dasilva
Copy link
Contributor

Description

Looks like issue: #2209
Was not complete. So here dictpool is completely gone

Would love to start using fiber for my own projects. And the less 3rd party packages the better in my opinion 馃槂

Fixes #2209

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • This change requires a documentation update

Checklist:

  • For new functionalities I follow the inspiration of the express js framework and built them similar in usage
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation - /docs/ directory for https://docs.gofiber.io/
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • If new dependencies exist, I have checked that they are really necessary and agreed with the maintainers/community (we want to have as few dependencies as possible)
  • I tried to make my code as fast as possible with as few allocations as possible
  • For new code I have written benchmarks so that they can be analyzed and improved

Commit formatting:

Use emojis on commit messages so it provides an easy way of identifying the purpose or intention of a commit. Check out the emoji cheatsheet here: https://gitmoji.carloscuesta.me/

Looks like issue:
gofiber#2209
Was not complete. So here dictpool is completely gone
@welcome
Copy link

welcome bot commented Jul 10, 2023

Thanks for opening this pull request! 馃帀 Please check out our contributing guidelines. If you need help or want to chat with us, join us on Discord https://gofiber.io/discord

@andre-dasilva andre-dasilva changed the title 馃┕ Fix: dictpool is not complety gone 馃┕ Fix: dictpool is not completely gone Jul 10, 2023
@ReneWerner87 ReneWerner87 merged commit 58270e2 into gofiber:master Jul 11, 2023
17 checks passed
@welcome
Copy link

welcome bot commented Jul 11, 2023

Congrats on merging your first pull request! 馃帀 We here at Fiber are proud of you! If you need help or want to chat with us, join us on Discord https://gofiber.io/discord

@andre-dasilva andre-dasilva deleted the feature/remove-dictpool branch July 12, 2023 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

馃悰 [Bug]: dictpool is deprecated
2 participants