🔥 Feature: add ability to print custom message on startup

[Saman-Safaei]

add a function in listener.go to print out the developer provided custom message

[welcome]

Thanks for opening this pull request! 🎉 Please check out our contributing guidelines. If you need help or want to chat with us, join us on Discord https://gofiber.io/discord

[efectn]

I think it's better idea to improve onListen hook instead of adding new config

[gaby]

I think it's better idea to improve onListen hook instead of adding new config

Agree

[ghost]

I think it's better idea to improve onListen hook instead of adding new config

@efectn So, something like this? (this is just a mock-up, and does not take prefork into account)

func (app *App) SetStartupMessage(fun ...func() error) {
	// disable default startup message
	app.config.DisableStartupMessage = true

	// add each func to the onListen hook
	app.hooks.onListen = append(app.hooks.onListen, fun...)
}

and it allows for this:

app := fiber.New()

app.SetStartupMessage(
	func() error {
		log.Println("Hello, ")
		return nil
	}, func() error {
		log.Println("World!")
		return nil
	},
)

log.Fatal(app.Listen(":9090"))

2023/06/02 15:03:13 Hello, 
2023/06/02 15:03:13 World!
^Csignal: interrupt

[efectn]

I think it's better idea to improve onListen hook instead of adding new config

@efectn So, something like this? (this is just a mock-up, and does not take prefork into account)

func (app *App) SetStartupMessage(fun ...func() error) {
	// disable default startup message
	app.config.DisableStartupMessage = true

	// add each func to the onListen hook
	app.hooks.onListen = append(app.hooks.onListen, fun...)
}

and it allows for this:

app := fiber.New()

app.SetStartupMessage(
	func() error {
		log.Println("Hello, ")
		return nil
	}, func() error {
		log.Println("World!")
		return nil
	},
)

log.Fatal(app.Listen(":9090"))

2023/06/02 15:03:13 Hello, 
2023/06/02 15:03:13 World!
^Csignal: interrupt

I think it's better idea to improve onListen hook instead of adding new config

@efectn So, something like this? (this is just a mock-up, and does not take prefork into account)

func (app *App) SetStartupMessage(fun ...func() error) {
	// disable default startup message
	app.config.DisableStartupMessage = true

	// add each func to the onListen hook
	app.hooks.onListen = append(app.hooks.onListen, fun...)
}

and it allows for this:

app := fiber.New()

app.SetStartupMessage(
	func() error {
		log.Println("Hello, ")
		return nil
	}, func() error {
		log.Println("World!")
		return nil
	},
)

log.Fatal(app.Listen(":9090"))

2023/06/02 15:03:13 Hello, 
2023/06/02 15:03:13 World!
^Csignal: interrupt

Hooks handlers accept parameters as you can see here https://github.com/gofiber/fiber/blob/master/hooks.go#L8

We can pass needed variables to hook like this. However, it'll break handler signature. Perhaps we put them into a struct and pass it as variadic, so it won't break compatibility

[efectn]

I'd recommend something like this:

type ListenData struct {
	Host string
	Port string
	TLS  string
}

app.Hooks().OnListen(func(data ...ListenData) error {
	if fiber.IsChild() {
		return nil
	}

	fmt.Print(data[0].Host)

	return nil
})

Note: Using variadic not to break backward-compatibility.

[ReneWerner87]

check my hint

[Saman-Safaei]

check my hint

I fixed that

[efectn]

@Saman-Safaei can you add unit tests and update docs. Also check hooks tests if there are invalid ones

[ghost]

Can you take a look at the new linter warnings/errors?

[ghost]

Please revert the f98133f commit.
While the go.mod does specify go 1.20, tests still run with go 1.17-1.20, and 1.17 does not contain any yet.

[efectn]

@Saman-Safaei can you add nolint flag for a method that isTLS param is used.

You can check other nolint flag usages for an example

[welcome]

Congrats on merging your first pull request! 🎉 We here at Fiber are proud of you! If you need help or want to chat with us, join us on Discord https://gofiber.io/discord