Fix toString for TagNode #633
Merged
+64
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@goccy I'm not sure why the pipeline keeps failing. |
|
This branch must be merged with the upstream branch beforehand |
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #633 +/- ##
==========================================
- Coverage 77.37% 77.34% -0.04%
==========================================
Files 22 22
Lines 7890 7905 +15
==========================================
+ Hits 6105 6114 +9
- Misses 1368 1372 +4
- Partials 417 419 +2 |
|
Done, I thought I already did that, but apparently not |
goccy
reviewed
Feb 3, 2025
LarsStegman
force-pushed
the
custommarshal-tags
branch
from
addc412 to
f74879c
Compare
goccy
approved these changes
Feb 4, 2025
|
LGTM ! Thank you for your contribution ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #401