Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AutoInt option #671

Merged
merged 1 commit into from
Feb 25, 2025
Merged

Add AutoInt option #671

merged 1 commit into from
Feb 25, 2025

Conversation

shuheiktgw
Copy link
Collaborator

@shuheiktgw shuheiktgw commented Feb 23, 2025

Closes #427. Some YAML libraries automatically convert float values to integers when possible. However, this is not currently supported in goccy/go-yaml. While users can work around this issue by implementing custom marshalers, it would be more convenient to provide an option that enables this behavior.

Thank you for your review!

  • Describe the purpose for which you created this PR.
  • Create test code that corresponds to the modification

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.63%. Comparing base (abc7083) to head (3d500f7).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #671      +/-   ##
==========================================
+ Coverage   77.61%   77.63%   +0.01%     
==========================================
  Files          22       22              
  Lines        7953     7959       +6     
==========================================
+ Hits         6173     6179       +6     
  Misses       1362     1362              
  Partials      418      418              

@shuheiktgw shuheiktgw requested a review from goccy February 23, 2025 08:20
Copy link
Owner

@goccy goccy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution !!!! LGTM 👍

@goccy goccy merged commit 944206a into master Feb 25, 2025
20 checks passed
@goccy goccy deleted the add_auto_int_option branch February 25, 2025 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unwanted int to float conversion
3 participants