Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manually closing the browser opened with rod in windows will not clean up the windows process #378

Closed
zobx opened this issue Mar 23, 2021 · 2 comments
Labels
needs info The description is not enough to tackle the problem

Comments

@zobx
Copy link

zobx commented Mar 23, 2021

Rod Version: v0.96.1

func main() {
	wsUrl, err := launcher.New().
		Delete("enable-automation").
		Set("ignore-certificate-errors").
		Set("ignore-certificate-errors-spki-list").
		Set("ignore-ssl-errors").
		Headless(false).
		Launch()
	if err != nil {
		return
	}
	browser := rod.New().ControlURL(wsUrl).MustConnect()
	browser.MustPage("https://www.google.com")
	select {
	}
}

1616494599(1)

@zobx zobx added the question Questions related to rod label Mar 23, 2021
@gh-robot
Copy link

Please add a valid **Rod Version:** v0.0.0 to your issue. Current version is v0.96.1
generated by check-issue

@ysmood
Copy link
Member

ysmood commented Mar 23, 2021

#322

@ysmood ysmood closed this as completed Mar 23, 2021
@ysmood ysmood added needs info The description is not enough to tackle the problem and removed question Questions related to rod labels Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs info The description is not enough to tackle the problem
Projects
None yet
Development

No branches or pull requests

3 participants