feat: add image validation #982
Conversation
the-fanan
force-pushed
the
feat-add-image-validation
branch
from
46de0f3
to
bc7329e
Compare
|
@hjwk can you help review this please? |
baked_in.go
Outdated
| _, err = file.Seek(0, io.SeekStart) | ||
| if err != nil { | ||
| panic(fmt.Sprintf("Could not reset seek start for file. Error: %s", err)) | ||
| } |
There was a problem hiding this comment.
I'm not sure why the seek is required? should be removed from what I can tell.
There was a problem hiding this comment.
While reading data on the mime type of the file, the offset for the reader is moved away from the beginning of the file and this may cause issues for other parts of the program that need to read from that file. Using seek ensures that after the mime type is read, the offset of the reader is returned to the beginning of the file so that there will be no issues for other parts of the program that will need to read from that file.
There was a problem hiding this comment.
Right I understand what Seek does and why one would need to use it but in this case the file handle is closed when this function ends because of the defer file.Close() and nothing else tries to read using that handle and so there is no need to Seek from what I can tell.
Sync With Upstream
…feat-add-image-validation
|
Let's ship this please 👍 |
Sync with upstream
…feat-add-image-validation
| @@ -1321,6 +1321,11 @@ func RegisterDefaultTranslations(v *validator.Validate, trans ut.Translator) (er | |||
| translation: "{0} deve ser um valor booleano válido", | |||
| override: false, | |||
| }, | |||
| { | |||
| tag: "image", | |||
| translation: "{0} deve ser uma imagen válido", | |||
There was a problem hiding this comment.
The correct translation is
"{0} deve ser uma imagem válida"
Enhances
Make sure that you've checked the boxes below before you submit PR:
☑️ Tests exist or have been written that cover this particular change.
This PR does the following:
README.mddocument to include the added image validationMotivation:
@go-playground/validator-maintainers