Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for skip_unless tag in validator #976

Merged
merged 8 commits into from
Apr 29, 2023

Conversation

JahanviAggarwal
Copy link
Contributor

Fixes Or Enhances

Make sure that you've checked the boxes below before you submit PR:

  • Tests exist or have been written that cover this particular change.

@go-playground/validator-maintainers

@JahanviAggarwal JahanviAggarwal requested a review from a team as a code owner July 10, 2022 12:55
@coveralls
Copy link

coveralls commented Jul 10, 2022

Coverage Status

Coverage increased (+0.02%) to 74.193% when pulling 54ff0b3 on JahanviAggarwal:master into 9e2ea40 on go-playground:master.

@JahanviAggarwal
Copy link
Contributor Author

@deankarn Can you please review this PR?

@deankarn
Copy link
Contributor

Thanks for the PR @JahanviAggarwal , sorry it took me this long to get to it.

Would you be able to resolve the conflicts and I can get it merged.

@JahanviAggarwal
Copy link
Contributor Author

@deankarn I have resolved the conflicts.
Can you please merge this?

@deankarn deankarn merged commit 1bc3651 into go-playground:master Apr 29, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants