Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update errors.go #975

Merged
merged 2 commits into from
Jan 14, 2024
Merged

Update errors.go #975

merged 2 commits into from
Jan 14, 2024

Conversation

maltsev25
Copy link
Contributor

@maltsev25 maltsev25 commented Jul 7, 2022

fix for aliases
translate work incorrect for registered aliases

Fixes Or Enhances

Make sure that you've checked the boxes below before you submit PR:

  • Tests exist or have been written that cover this particular change.

@go-playground/validator-maintainers

@maltsev25 maltsev25 requested a review from a team as a code owner July 7, 2022 18:20
@coveralls
Copy link

coveralls commented Jul 7, 2022

Coverage Status

Coverage increased (+0.005%) to 74.188% when pulling 0dba140 on maltsev25:patch-1 into c7e0172 on go-playground:master.

Copy link

@hjwk hjwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you squash your three commits into 1 ?

errors.go Show resolved Hide resolved
@maltsev25
Copy link
Contributor Author

@deankarn Can you please review this PR?

Copy link
Contributor

@deankarn deankarn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I will try to merge and release this weekend, have a lot going on so may be a few days.

@deankarn deankarn merged commit add493f into go-playground:master Jan 14, 2024
d1slike pushed a commit to txix-open/validator that referenced this pull request Apr 1, 2024
**fix for aliases**
translate work incorrect for registered aliases

## Fixes Or Enhances


**Make sure that you've checked the boxes below before you submit PR:**
- [x] Tests exist or have been written that cover this particular
change.

@go-playground/validator-maintainers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants