Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix validator excluded_if #939

Merged
merged 1 commit into from
Apr 29, 2023
Merged

Fix validator excluded_if #939

merged 1 commit into from
Apr 29, 2023

Conversation

CorentinClabaut
Copy link
Contributor

Fixes Or Enhances

closes #938

Make sure that you've checked the boxes below before you submit PR:

  • Tests exist or have been written that cover this particular change.

@go-playground/validator-maintainers

@CorentinClabaut CorentinClabaut requested a review from a team as a code owner May 4, 2022 09:49
@coveralls
Copy link

Coverage Status

Coverage remained the same at 74.177% when pulling 145ebc8 on CorentinClabaut:master into 9e2ea40 on go-playground:master.

@PualrDwade
Copy link

please merge into master ASAP~

@violin0622 violin0622 mentioned this pull request Aug 17, 2022
Closed
1 task
@smares
Copy link

smares commented Dec 16, 2022 •
edited

Just stumbled upon this bug today. What's holding this PR back?

@jenoudet
Copy link
Contributor

jenoudet commented Jan 30, 2023 •
edited

Any updates on this? Would love for this fix to be merged. @deankarn

@smares smares mentioned this pull request Feb 2, 2023
Merged
1 task
@Daniel-W-Innes
Copy link

Now that the fix to excluded_unless has been merged, no built-in validator provides this functionality in the latest release. Is there any update on when this will be merged?

@deankarn deankarn merged commit b7df869 into go-playground:master Apr 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deankarn deankarn deankarn approved these changes

@bendeckdavid bendeckdavid bendeckdavid approved these changes

@PualrDwade PualrDwade PualrDwade approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Excluded_if Doesn't behave as expected
8 participants
@CorentinClabaut @coveralls @PualrDwade @smares @jenoudet @Daniel-W-Innes @deankarn @bendeckdavid