Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add omitnil modifier #1187

Merged
merged 3 commits into from Nov 4, 2023
Merged

Add omitnil modifier #1187

merged 3 commits into from Nov 4, 2023

Conversation

tarampampam
Copy link
Contributor

Fixes Or Enhances

Related issue: #1186

Make sure that you've checked the boxes below before you submit PR:

  • Tests exist or have been written that cover this particular change.

@go-playground/validator-maintainers

@tarampampam tarampampam requested a review from a team as a code owner October 28, 2023 10:25
@coveralls
Copy link

Coverage Status

coverage: 73.849%. remained the same when pulling 8a856d6 on tarampampam:master into 94a637a on go-playground:master.

@tarampampam
Copy link
Contributor Author

Friendly ping @yjagdale @deankarn 😃

yjagdale
yjagdale approved these changes Oct 28, 2023
View reviewed changes
Copy link
Contributor

@yjagdale yjagdale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tarampampam tarampampam changed the title Add omitnill modifier Add omitnil modifier Oct 30, 2023
deankarn
deankarn approved these changes Nov 4, 2023
View reviewed changes
Copy link
Contributor

@deankarn deankarn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deankarn deankarn merged commit aa96909 into go-playground:master Nov 4, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deankarn deankarn deankarn approved these changes

@yjagdale yjagdale yjagdale approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tarampampam @coveralls @deankarn @yjagdale