fix: windows support for path loading #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredbi
force-pushed
the
fix/windows-invalid-url
branch
from
cdba2d9
to
d1d6372
Compare
|
need to run an integration test with go-swagger's test suite |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #71 +/- ##
==========================================
+ Coverage 85.59% 86.38% +0.79%
==========================================
Files 13 13
Lines 1569 1587 +18
==========================================
+ Hits 1343 1371 +28
+ Misses 193 183 -10
Partials 33 33 ☔ View full report in Codecov by Sentry. |
fredbi
force-pushed
the
fix/windows-invalid-url
branch
from
29362e3
to
86392de
Compare
On windows, there are quite a few specifics when it comes to resolving a local file. This complexity stemmed from the desire to support common, albeit invalid URI constructs for windows. Overall, the original sin of this function has been to ignore the host part of an URI, but now we can't really break this behavior. * fixes go-openapi#72 * refactored the local path pre-processing, so the windows-specifics appear more clearly * fixed a few inconsistencies on windows file URIs and guarded against a panic * test: refactored tests for the local file strategy, now table-driven and more systematic * doc: added detailed documentation to LoadStrategy() * ci: re-enacted tests on windows * ci: temporarily muted past linting issues: relinting is deferred to another PR Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
fredbi
force-pushed
the
fix/windows-invalid-url
branch
from
86392de
to
6c3422a
Compare
fredbi
added a commit
to fredbi/go-swagger
that referenced
this pull request
Dec 5, 2023
Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
fredbi
added a commit
to fredbi/go-swagger
that referenced
this pull request
Dec 5, 2023
Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
fredbi
changed the title
|
Fixing this, I now realize the original sin of the LoadStrategy() func when dealing with file:// URI... Well now we have to keep it this way, and make sure that this also works on windows. In hindsight, I have some regrets not to impose earlier a strict approach to file URIs... At least it works, runs tests, doesn't break go-swagger CI... |
Merged
youyuanwu
approved these changes
Dec 6, 2023
casualjim
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.