updated & relinted #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
fredbi
commented
Dec 4, 2023
fredbi
commented
- updated go version, in line with other go-openapi packages
- updated golangci-lint config
- relinted (essentially test code)
- removed code guards with build tags for pre19
- updated github actions
- updated README (badges)
fredbi
force-pushed
the
chore/update-linting
branch
2 times, most recently
from
dba2685
to
5033126
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #70 +/- ##
==========================================
+ Coverage 84.94% 86.37% +1.43%
==========================================
Files 13 12 -1
Lines 1587 1585 -2
==========================================
+ Hits 1348 1369 +21
+ Misses 207 183 -24
- Partials 32 33 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
fredbi
force-pushed
the
chore/update-linting
branch
2 times, most recently
from
67e2a01
to
793d6e2
Compare
|
builds on top of #71, to separate the fix on windows that prevented to run a CI on all platforms |
youyuanwu
approved these changes
Dec 6, 2023
casualjim
approved these changes
Dec 6, 2023
* updated go version, in line with other go-openapi packages * updated golangci-lint config * relinted (essentially test code) * removed code guards with build tags for pre19 * updated github actions, added run on windows * updated README (badges) Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
fredbi
force-pushed
the
chore/update-linting
branch
from
793d6e2
to
4f6e589
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.