check for nil pointers before calling IsZero. #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids panics when a nil pointer to a type that implements zeroable interface is passed to IsZero Signed-off-by: Michał Szczygieł <1153719+mszczygiel@users.noreply.github.com>
piepmatz
suggested changes
Mar 24, 2023
util.go
Outdated
| v := reflect.ValueOf(data) | ||
| // check for nil data | ||
| switch v.Kind() { | ||
| case reflect.Interface, reflect.Ptr: |
There was a problem hiding this comment.
How about also checking for reflect.Slice and removing the (now duplicated) check below then?
There was a problem hiding this comment.
changed, thanks!
util_test.go
Outdated
Comment on lines
494
to
510
| type dummyZeroable struct { | ||
| zero bool | ||
| } | ||
|
|
||
| func (d dummyZeroable) IsZero() bool { | ||
| return d.zero | ||
| } | ||
| func TestZeroableNilIsZero(t *testing.T) { | ||
| var d *dummyZeroable | ||
|
|
||
| assert.True(t, IsZero(d)) | ||
| } | ||
|
|
||
| func TestZeroableInterfaceIsRespected(t *testing.T) { | ||
| assert.False(t, IsZero(dummyZeroable{false})) | ||
| assert.True(t, IsZero(dummyZeroable{true})) | ||
| } |
There was a problem hiding this comment.
Can't we integrate this is the existing TestIsZero test?
There was a problem hiding this comment.
Yes, we can. Moved, thanks!
youyuanwu
approved these changes
Mar 25, 2023
Codecov Report
@@ Coverage Diff @@
## master #67 +/- ##
==========================================
+ Coverage 85.49% 85.59% +0.10%
==========================================
Files 13 13
Lines 1565 1569 +4
==========================================
+ Hits 1338 1343 +5
+ Misses 194 193 -1
Partials 33 33
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Michał Szczygieł <1153719+mszczygiel@users.noreply.github.com>
Signed-off-by: Michał Szczygieł <1153719+mszczygiel@users.noreply.github.com>
|
Looks good. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids panics when a nil pointer to a type that implements zeroable interface is passed to IsZero
fixes #66