When registering as a slave we should be using the host's hostname, not the server's hostname. #34
Comments
gdey
added a commit
to gdey/go-mysql
that referenced
this issue
Jan 22, 2016
When registering as a slave we are using the wrong hostname. It should be our hostname, not the hostname name of the server we are connecting to.
gdey
added a commit
to gdey/go-mysql
that referenced
this issue
Jan 22, 2016
When registering as a slave we are using the wrong hostname. It should be our hostname, not the hostname name of the server we are connecting to. Fixed issue with using the wrong variable.
siddontang
added a commit
that referenced
this issue
Jan 26, 2016
This fixes issue #34. Using the wrong hostname.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We have a bug in writeRegisterSlaveCommand (https://github.com/siddontang/go-mysql/blob/master/replication/binlogsyncer.go#L414-L417) where we are using the host name of the server we are connecting to instead of the host we are on.
This makes is confusing when looking at the
show slave statusoutput on the master.We should just use os.Hostname() here.
The text was updated successfully, but these errors were encountered: