slogr: fix unintended API break in v1.4.0 #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An API break in https://github.com/go-logr/logr/pull/237/files#r1434203442 wasn't noticed because the apidiff tool ran with 1.20.x.
logr v0.7.0 had slogr.NewSlogHandler. We must keep that function for API compatibility. https://github.com/go-logr/logr/pull/237/files#r1434203442 accidentally renamed it.
|
Given that It's cheap, so let's keep it... |
|
In this case, fine. But in general, I don't think we need to be burdened with decisions we make in 0.x series tags. |
pohly
changed the title
|
I was confused (time for Christmas break...): logr is at 1.x, so it has strong API guarantees (no matter how new the call). 0.8.0 is the logcheck release that I just did. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
logr v1.3.0 had slogr.NewSlogHandler. We must keep that function for API
compatibility. https://github.com/go-logr/logr/pull/237/files#r1434203442
accidentally renamed it.