Increase the number of PBKDF2 iterations to 600k #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit increases the number of PBKDF2 iterations used in PBES2 from 100k to 600k. In past few months the new password recommendations are to use at least 600k with SHA-256. See https://cheatsheetseries.owasp.org/cheatsheets/Password_Storage_Cheat_Sheet.html#pbkdf2 Signed-off-by: Mariano Cano <mariano.cano@gmail.com>
pgporada
approved these changes
Jun 26, 2023
beautifulentropy
approved these changes
Jun 28, 2023
aarongable
approved these changes
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit increases the number of PBKDF2 iterations used in PBES2 from 100k to 600k. In past few months the new password recommendations are to use at least 600k with SHA-256.
See https://cheatsheetseries.owasp.org/cheatsheets/Password_Storage_Cheat_Sheet.html#pbkdf2
PS: I implemented PBES2 support in the original
square/go-josea few years ago.