Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup: set rsa.SignPKCS1v15 RandReader input param to nil #40

Open
pgporada opened this issue Mar 15, 2023 · 1 comment
Open

Cleanup: set rsa.SignPKCS1v15 RandReader input param to nil #40

pgporada opened this issue Mar 15, 2023 · 1 comment

Comments

@pgporada
Copy link
Collaborator

As of go 1.20, rsa.SignPKCS1v15 input parameters state that:

the random parameter is legacy and ignored, and it can be nil.

We want projects that are building go-jose with versions older than 1.20.x to continue being able to build go-jose for the foreseeable future.. After sufficient time has passed, we'll clean up this code. What does sufficient time mean? I don't know yet, but I'll probably see you in a few years. 👋🏼

@maraino
Copy link

maraino commented Mar 16, 2023

Currently, go-jose works on the latest version, Go 1.20.2, and I don't think Go will change that in any Go 1.x version, it will break a bunch of things if they do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants