allow ignoring escape and quoting #221
Merged
+6
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please mind, this is my first PR in an open source project :) if I missed anything let me know. |
|
thank you for your first pr, lgtm ;) |
PuneetPunamiya
pushed a commit
to PuneetPunamiya/postgres
that referenced
this pull request
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did this pull request do?
This PR allows the developer to take responsability of column names and table names correctness,
by correctness I mean no special characters and no postgres reserved keywords.
Benefits :
less run time for checking each byte for an invalid character,
more flexibility when the developer wants to ignore casing in his database columns and table names
User Case Description
In my case, the double quotes around table names and columns, make my query case sensitive to the casing of table names
and columns.
In my case, performance is crucial, avoiding going over bytes in the query, could be significant on the long run