Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: not clause with or condition #6984

Merged
merged 1 commit into from Apr 25, 2024
Merged

fix: not clause with or condition #6984

merged 1 commit into from Apr 25, 2024

Conversation

a631807682
Copy link
Member

  • Do only one thing
  • Non breaking API changes
  • Tested

What did this pull request do?

close #6942

User Case Description

a631807682
a631807682 commented Apr 22, 2024
View reviewed changes
Copy link
Member Author

@a631807682 a631807682 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since Not does not handle NegationExpressionBuilder under Or condition, the same condition is not added here.

https://github.com/go-gorm/gorm/pull/6984/files#diff-3d84fe4bf1e6013a668e8a6b17361f6656aee4d7562c7fff9939efbe39e81738L184

https://github.com/go-gorm/gorm/pull/6984/files#diff-3d84fe4bf1e6013a668e8a6b17361f6656aee4d7562c7fff9939efbe39e81738R156

@jinzhu jinzhu merged commit 207f1ac into go-gorm:master Apr 25, 2024
32 of 35 checks passed
@a631807682 a631807682 deleted the fix_not_clause branch April 26, 2024 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jinzhu jinzhu jinzhu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Behavior of .Not(Where().Or()) has changed
2 participants
@a631807682 @jinzhu