Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix schema GetIdentityFieldValuesMap interface or ptr #6417

Merged
merged 1 commit into from Aug 19, 2023

Conversation

uptutu
Copy link
Contributor

@uptutu uptutu commented Jun 16, 2023

  • [ x ] Do only one thing
  • [ x ] Non breaking API changes
  • [ x ] Tested

What did this pull request do?

我的使用场景遇到了 类型为 interface 的问题

User Case Description

使用 reflect 构建的 model 对象在 Find 中 Preload 失效

#6416

Copy link
Member

@a631807682 a631807682 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add some unit tests?

@tsaquet
Copy link

tsaquet commented Aug 18, 2023

I had the same problem, just tested the patch, it works well !
Do you think you can merge the PR soon ?
Thanks in advance !

@jinzhu jinzhu merged commit 7e44f73 into go-gorm:master Aug 19, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants