fix: limit(0).offset(b) return all data, where b <= 0
#6191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hanwn
changed the title
limit(0).offset(0) return all datalimit(0).offset(0) return all data (https://github.com/go-gorm/gorm/issues/6188#issue-1641432003)
Hanwn
changed the title
limit(0).offset(0) return all data (https://github.com/go-gorm/gorm/issues/6188#issue-1641432003)limit(0).offset(0) return all data https://github.com/go-gorm/gorm/issues/6188#issue-1641432003
Hanwn
changed the title
limit(0).offset(0) return all data https://github.com/go-gorm/gorm/issues/6188#issue-1641432003limit(0).offset(0) return all data
Hanwn
changed the title
limit(0).offset(0) return all datalimit(0).offset(b) return all data, where b >= 0
Hanwn
changed the title
limit(0).offset(b) return all data, where b >= 0limit(0).offset(b) return all data, where b <= 0
a631807682
approved these changes
Mar 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did this pull request do?
fix for issue #6188 (comment)
User Case Description
when execute
db.Limit(0).Offset(0).Where("id > ?", 10).Find(&users), it will return all data satified where condition. Namely, sql generated isselect * from users where id > 10, but notselect * from users where id > 10 limit 0, which is diff from sql semantics.