Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(migrator): non-standard codes #6180

Merged
merged 1 commit into from Apr 11, 2023

Conversation

demoManito
Copy link
Member

  • Do only one thing
  • Non breaking API changes
  • Tested

What did this pull request do?

User Case Description

@@ -135,12 +135,14 @@ func (m Migrator) AutoMigrate(values ...interface{}) error {

if foundColumn == nil {
// not found, add column
if err := execTx.Migrator().AddColumn(value, dbName); err != nil {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

err is a shadowed variable

@demoManito demoManito force-pushed the refactor/migrator/non-standard branch from 5eeda0c to 9ab440c Compare March 24, 2023 12:49
@jinzhu jinzhu merged commit 05bb9d6 into go-gorm:master Apr 11, 2023
23 checks passed
@demoManito demoManito deleted the refactor/migrator/non-standard branch April 11, 2023 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants