From 7b1fb0bd732448adad0ea097983fc663700c1978 Mon Sep 17 00:00:00 2001 From: jessetang <1430482733@qq.com> Date: Fri, 15 Mar 2024 14:14:48 +0800 Subject: [PATCH] fix(scan): array element is set to a zero value (#6890) * fix(scan): array element is set to a zero value * add test * fix test * optimization --- scan.go | 4 +++- tests/query_test.go | 19 +++++++++++++++++++ 2 files changed, 22 insertions(+), 1 deletion(-) diff --git a/scan.go b/scan.go index 54cd6769d..415b9f0d7 100644 --- a/scan.go +++ b/scan.go @@ -274,7 +274,9 @@ func Scan(rows Rows, db *DB, mode ScanMode) { if !update || reflectValue.Len() == 0 { update = false - if !isArrayKind { + if isArrayKind { + db.Statement.ReflectValue.Set(reflect.Zero(reflectValue.Type())) + } else { // if the slice cap is externally initialized, the externally initialized slice is directly used here if reflectValue.Cap() == 0 { db.Statement.ReflectValue.Set(reflect.MakeSlice(reflectValue.Type(), 0, 20)) diff --git a/tests/query_test.go b/tests/query_test.go index e780e3bfe..c0259a14a 100644 --- a/tests/query_test.go +++ b/tests/query_test.go @@ -1409,3 +1409,22 @@ func TestQueryError(t *testing.T) { }, Value: 1}).Scan(&p2).Error AssertEqual(t, err, gorm.ErrModelValueRequired) } + +func TestQueryScanToArray(t *testing.T) { + err := DB.Create(&User{Name: "testname1", Age: 10}).Error + if err != nil { + t.Fatal(err) + } + + users := [2]*User{{Name: "1"}, {Name: "2"}} + err = DB.Model(&User{}).Where("name = ?", "testname1").Find(&users).Error + if err != nil { + t.Fatal(err) + } + if users[0] == nil || users[0].Name != "testname1" { + t.Error("users[0] not covere") + } + if users[1] != nil { + t.Error("users[1] should be empty") + } +}