Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: rm conn pool #114

Merged
merged 1 commit into from
Aug 19, 2023
Merged

feat: rm conn pool #114

merged 1 commit into from
Aug 19, 2023
+1 −106

Conversation

qqxhb
Copy link
Member

@qqxhb qqxhb commented Aug 18, 2023

  • Do only one thing
  • Non breaking API changes
  • Tested

What did this pull request do?

User Case Description

Sorry, something went wrong.

@jinzhu jinzhu merged commit d90889f into master Aug 19, 2023
@lzakharov
Copy link
Contributor

lzakharov commented Sep 8, 2023 •
edited
Loading

Hi! What was the reason for the removal?
Also to notice, this tests are broken now.

@jinzhu
Copy link
Member

jinzhu commented Sep 11, 2023

Hi @lzakharov

Sorry for the revert, lots of break changes were reported after merging the PR due to the ConnPool changes, so we implemented the original request in another way. refer go-gorm/gorm@fef4294#diff-3133f5a3c5ce0087b14a818cff68c205e4aa03eb83b4f0f7f06137ae2b4351ecL375

@jinzhu jinzhu deleted the feat_rm_ctxconnpool branch September 11, 2023 11:20
@lzakharov
Copy link
Contributor

Thanks for the answer and another solution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@qqxhb @lzakharov @jinzhu