Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stack overflow introduced with v1.4.2 #110

Closed
tfonfara opened this issue Aug 2, 2023 · 1 comment
Closed

Stack overflow introduced with v1.4.2 #110

tfonfara opened this issue Aug 2, 2023 · 1 comment
Assignees
@jinzhu

Comments

@tfonfara
Copy link

tfonfara commented Aug 2, 2023

GORM Playground Link

go-gorm/playground#633

Description

Starting with version 1.4.2, dbresolver is causing a stack overflow if the database connection is being closed. This issue is not happening with 1.4.1 or prior versions.
lzakharov added a commit to lzakharov/dbresolver that referenced this issue Aug 8, 2023
@lzakharov
fix: stack overflow on GetDBConnWithContext (go-gorm#110)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
9086f6a
@lzakharov lzakharov mentioned this issue Aug 8, 2023
Closed
@lzakharov
Copy link
Contributor

Hi, @tfonfara!

Thank you for the issue. I've added possible solution: #111. According to the documentation it's not safe to reuse *gorm.DB after chain and finisher methods, so imho in practice it's better to use separate sessions.

@jinzhu jinzhu closed this as completed in 3ccf9c6 Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jinzhu jinzhu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jinzhu @tfonfara @lzakharov